Update Enterprise admonitions #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kenjenkins
approved these changes
Feb 1, 2024
| @@ -54,6 +54,10 @@ By configuring your applications to route requests to Pomerium’s Proxy service | |||
|
|
|||
| ## External data sources (Enterprise) | |||
|
|
|||
| :::enterprise Pomerium Enterprise | |||
There was a problem hiding this comment.
side note: now that we have a custom component for this admonition, we may want to implement a default title in it, so we wouldn't need to repeat "Pomerium Enterprise" each time we use it
There was a problem hiding this comment.
Based on their example, the title must be manually entered: https://docusaurus.io/docs/markdown-features/admonitions#custom-admonition-type-components. If it's possible to add a default title, we can do that for sure.
Co-authored-by: Kenneth Jenkins <[email protected]>
backport-actions-token bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* adds ent admonition to authentication page * adds ent admonition to authorize * adds ent admonition to device identity section * adds ent admonition to integrations page * adds ent admonitions to two guides * fixes incorrect link * fixes cspell typo * Update content/docs/capabilities/authorization.mdx Co-authored-by: Kenneth Jenkins <[email protected]> --------- Co-authored-by: Kenneth Jenkins <[email protected]>
ZPain8464
added a commit
that referenced
this pull request
Feb 2, 2024
Update Enterprise admonitions (#1215) * adds ent admonition to authentication page * adds ent admonition to authorize * adds ent admonition to device identity section * adds ent admonition to integrations page * adds ent admonitions to two guides * fixes incorrect link * fixes cspell typo * Update content/docs/capabilities/authorization.mdx --------- Co-authored-by: zachary painter <[email protected]> Co-authored-by: Kenneth Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly updates old admonitions, but it also adds a few:
I should add this is just the initial use case for the admonition. I'd like to strategically place it with more compelling text to help broadcast Enterprise features and use cases.
Resolves https://github.com/pomerium/internal/issues/1711